Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Backport of PR 12686 on v2.2.x#12698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

timhoffm
Copy link
Member

PR Summary

Backports of#12686 and#12431.

Note: I only backport the code of#12431, not the tests and test images. But I assume that's ok as changes are made against master and tested there.

@tacaswelltacaswell added this to thev2.2.4 milestoneNov 4, 2018
@tacaswell
Copy link
Member

Master has moved far enough away from the 2.2.x branch is is probably better to backport the tests as well.

tacaswell
tacaswell previously approved these changesNov 4, 2018
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am 50/50 on backporting the tests. Defer to a second reviewer.

@ImportanceOfBeingErnest
Copy link
Member

ImportanceOfBeingErnest commentedNov 8, 2018
edited
Loading

This may be a bit naive, but I'd say one should always backport the tests. Even with tests it's still possible to break things unconsciously, but at least it ensures not to break the very feature that is added.
With fewer and fewer users actively using the 2.2 branch it's also more likely that if something breaks it will not immediately be discovered.

If this gets backported to 2.2 then#12673 should as well, right?

@tacaswell
Copy link
Member

Oh, good catch@ImportanceOfBeingErnest !

I miss-read things, I am -0.5 on backporting these PRs as they are not critical bugs in 2.2.x

@tacaswelltacaswell dismissed theirstale reviewNovember 11, 2018 03:56

Misread the PR, thought this was fixing an existing issue with the collections.abc imports (which will eventually become an import failure).

@timhoffm
Copy link
MemberAuthor

Fine with not backporting.

@timhoffmtimhoffm deleted the backport-of-pr-12686-on-v2.2.x branchNovember 12, 2018 21:57
@QuLogicQuLogic modified the milestones:v2.2.4,unassignedNov 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@timhoffm@tacaswell@ImportanceOfBeingErnest@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp