test_constrainedlayout.py::test_colorbar_location is sometimes flaky; i.e. the constraint solver sometimes seems tochoose the wrong constraint. The flakiness is rare, but occasionally causes CI to not pass.

Also added a@pytest.mark.timeout(30) because I saw one instance where the CI timed out because of this test. I don't see that we do this elsewhere in the CI suite, so please feel free to tell me if this is incorrect.

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak added this to thev3.0.x milestone

Oct 31, 2018

jklymak added the topic: testing label

Oct 31, 2018

anntzer reviewed

Oct 31, 2018

View reviewed changes

lib/matplotlib/tests/test_constrainedlayout.pyShow resolvedHide resolved

jklymak mentioned this pull request

Oct 31, 2018

solver not always deterministic....nucleic/kiwi#57

Closed

jklymak force-pushed thetst_mark_colorbartest_flaky branch froma0c6e24 to674e42aCompare

October 31, 2018 19:13

TST: mark test_constrainedlayout.py::test_colorbar_location as flaky

504b29a

jklymak force-pushed thetst_mark_colorbartest_flaky branch from674e42a to504b29aCompare

October 31, 2018 19:59

tacaswell approved these changes

Oct 31, 2018

View reviewed changes

timhoffm approved these changes

Oct 31, 2018

View reviewed changes

timhoffm merged commitd0deb47 intomatplotlib:master

Oct 31, 2018

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request

Oct 31, 2018

Backport PRmatplotlib#12683: TST: mark test_constrainedlayout.py::te…

fe5130b

…st_colorbar_location as flaky

meeseeksmachine mentioned this pull request

Oct 31, 2018

Backport PR #12683 on branch v3.0.x (TST: mark test_constrainedlayout.py::test_colorbar_location as flaky)#12689

Merged

QuLogic added a commit that referenced this pull request

Nov 1, 2018

Merge pull request#12689from meeseeksmachine/auto-backport-of-pr-12…

ab3812d

…683-on-v3.0.xBackport PR#12683 on branch v3.0.x (TST: mark test_constrainedlayout.py::test_colorbar_location as flaky)

thoo added a commit to thoo/matplotlib that referenced this pull request

Nov 3, 2018

Merge branch 'master' ofhttps://github.com/matplotlib/matplotlib

ee90452

* 'master' ofhttps://github.com/matplotlib/matplotlib: (50 commits)  Set up CI with Azure Pipelines (matplotlib#12617)  Added comment for test.  Correctly remove nans when drawing paths with pycairo.  Improve docs on Axes limits and direction  Extend sphinx Makefile to cleanup completely  Remove explicit figure number  Update contributing.rst  Update contributing.rst  DOC: Add badge and link to making PR tutorial  Added test cases for scatter plot: 1) empty data/color, 2) pandas.Series with non-0 starting index.  TST: mark test_constrainedlayout.py::test_colorbar_location as flaky (matplotlib#12683)  Remove deprecation warnings in tests (matplotlib#12686)  Make ticks in demo_axes_rgb.py visible  Change ipython block to code-block  Improve linestyles example (matplotlib#12586)  document-textpath  Fix index out of bound error for testing first element of iterable.  TST: test that get_ticks works  FIX: fix error in colorbar.get_ticks not having valid data  Replaced warnings.warn with either logging.warnings or cbook._warn_external  ...