Apparently some axes don't allow acceptbbox_extra_artists kwarg. I could not track down how to get the parasite axes'get_tightbbox to accept this kwarg, but this fix seems to work fine.

The offending PR was#12363 where I introduced thebbox_extra_artists as a kwarg. That was probably a mistake because some axes subclasses out there may not impliment this kwarg.

This PR makes that kwarg optional - ifaxsubclass.get_tightbbox(renderer, bbox_extra_artists=artists) gives a TypeError, then we just call it w/o this kwarg.

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant

jklymak added this to thev3.0.x milestone

Oct 26, 2018

jklymak added topic: geometry manager

LayoutEngine, Constrained layout, Tight layout

topic: mpl_toolkit labels

Oct 26, 2018

dstansby approved these changes

Oct 26, 2018

View reviewed changes

Copy link

MemberAuthor

jklymak commentedOct 26, 2018•
edited
Loading

Note I still need to add a test or two. This shouldn’t have passed CI (EDIT: shuld not have passed CI when the original PR went in)...

EDIT: test added!

jklymak added2 commits

October 26, 2018 10:27

FIX: allow non bbox_extra_artists calls

b9f79b5

TST: test get_tightbbox for axes_grid1

ed621ad

jklymak force-pushed thefix-allow-non-bbox-exgtra-artists branch from985eae1 toed621adCompare

October 26, 2018 17:27

timhoffm approved these changes

Oct 28, 2018

View reviewed changes

timhoffm merged commit6af7450 intomatplotlib:master

Oct 28, 2018

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request

Oct 28, 2018

Backport PRmatplotlib#12635: FIX: allow non bbox_extra_artists calls

7c2b45d

meeseeksmachine mentioned this pull request

Oct 28, 2018

Backport PR #12635 on branch v3.0.x (FIX: allow non bbox_extra_artists calls)#12660

Merged

jklymak added a commit that referenced this pull request

Oct 29, 2018

Merge pull request#12660from meeseeksmachine/auto-backport-of-pr-12…

0593c59

…635-on-v3.0.xBackport PR#12635 on branch v3.0.x (FIX: allow non bbox_extra_artists calls)

QuLogic reviewed

Nov 10, 2018

View reviewed changes

lib/mpl_toolkits/tests/test_axes_grid1.py

		@@ -406,3 +406,18 @@ def test_image_grid():
		for i in range(4):
		grid[i].imshow(im)
		grid[i].set_title('test {0}{0}'.format(i))


		def test_gettightbbox():

Copy link

Member

QuLogicNov 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have you looked at the figure produced in this test? Is it working the way it's supposed to? I get oneAxes with one really bigAxes overlaid on top of it, but I'm not sure if that's the intended behaviour or not.

Copy link

MemberAuthor

jklymakNov 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, sorry, its not a very good test. But I'm not sure why axes_grid does that, so that's a different issue. The issue here was that the png being made was not being cropped properly to include the big box whenbbox_inches='tight' was used.