Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add explanations and examples to the docstring of violinplot#12585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
andreawwenyi wants to merge3 commits intomatplotlib:masterfromandreawwenyi:violinplot_docstring
Closed

add explanations and examples to the docstring of violinplot#12585

andreawwenyi wants to merge3 commits intomatplotlib:masterfromandreawwenyi:violinplot_docstring

Conversation

andreawwenyi
Copy link

Add explanations and examples to the docstring of violinplot to explain how violinplot handles differently w.r.t. sequence of vectors and 2D array.
Closes#12178

PR Summary

PR Checklist

  • [V] Has Pytest style unit tests
  • [V] Code isFlake 8 compliant
  • [V] New features are documented, with examples if plot related
  • [V] Documentation is sphinx and numpydoc compliant
  • [V] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [V] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

…in the difference between passing an array and passing a sequences of vectors.
Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR. I'm thinking you can condense this information a bit into one note.

@story645
Copy link
Member

Hi @wywang-nyu, this PR is very welcome and thank you for making it. Do you plan on making the requested changes?

Copy link
Author

@andreawwenyiandreawwenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

delete this explanation as it is already in the note

@andreawwenyi
Copy link
Author

Hi @wywang-nyu, this PR is very welcome and thank you for making it. Do you plan on making the requested changes?

Hi, sorry for the delay! I totally forgot about this. I just made the request changes, please review! Thank you.

dataset : Array or a sequence of vectors.
The input data.
dataset : 2D Array/Matrix or a sequence of vectors.
The input data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

don't need "the input data". Notes about data haven't been moved to notes section"

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

flake8 complains (see also the flake8 Travis CI build):

./lib/matplotlib/axes/_axes.py:7874:80: E501 line too long (133 > 79 characters)./lib/matplotlib/axes/_axes.py:7880:26: W291 trailing whitespace./lib/matplotlib/axes/_axes.py:7881:80: E501 line too long (116 > 79 characters)./lib/matplotlib/axes/_axes.py:7882:80: E501 line too long (108 > 79 characters)3     E501 line too long (133 > 79 characters)1     W291 trailing whitespace

Please fix to comply with our coding conventions.

@story645
Copy link
Member

closing because this got kind of addressed in#14107 but will totally reopen if @andrea-w-wang has the bandwidth to readdress this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 requested changes

@timhoffmtimhoffmtimhoffm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Violin plot inconsistency between list and numpy
3 participants
@andreawwenyi@story645@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp