Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Avoid quadratic behavior when accumulating stickies.#12546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
When plotting 10000 lines, this gives a ~10% improvement in performance.
| @@ -2405,12 +2405,12 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True): | |||
| if self.use_sticky_edges and (self._xmargin or self._ymargin): | |||
| stickies = [artist.sticky_edges for artist in self.get_children()] | |||
| x_stickies = sum([sticky.x for sticky in stickies], []) | |||
| y_stickies = sum([sticky.y for sticky in stickies], []) | |||
| x_stickies = np.array([x for sticky in stickies for x in sticky.x]) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
np.isclose is called just below anyways so converting to array here vs just below shouldn't affect performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems a fine tweak to me.
When plotting 10000 lines, this gives a ~10% improvement in performance.
xref#12542.
PR Summary
PR Checklist