Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Backport PR #12363 on branch v3.0.x#12512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Backport PR #12363 on branch v3.0.x#12512
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -321,6 +321,8 @@ def __init__(self, ax, direction): | |||
| raise KeyError("direction must be one of left, right, bottom, top") | |||
| def __call__(self, renderer): | |||
| vl = [self._get_func(ax.get_tightbbox(renderer, False), | |||
| ax.bbox) for ax in self._ax_list] | |||
| get_func = self._get_func_map[self._direction] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
self._get_func still exists in this branch, so I think this change was not strictly necessary, but it's probably fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ha no you were right - I chose the wrong branch for that change ;-)
547c5ab to65bedc5Compare
FIX: errors in get_position changes
PR Summary
PR Checklist