Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MAINT: numpy deprecates asscalar in 1.16#12478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
QuLogic approved these changesOct 10, 2018
tacaswell approved these changesOct 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we want to back-port this at all?
Do we want to backport to 2.2.x as this will prevent an eventual bug? |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 12, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 12, 2018
QuLogic added a commit that referenced this pull requestOct 12, 2018
…478-on-v3.0.xBackport PR#12478 on branch v3.0.x (MAINT: numpy deprecates asscalar in 1.16)
timhoffm pushed a commit that referenced this pull requestOct 13, 2018
10 tasks
timokau added a commit to timokau/nixpkgs that referenced this pull requestFeb 11, 2019
Numpy deprecated asscalar in 1.16. This will be fixed in the nextmatplotlib version, but to avoid deprecation warnings (and because theyare breaking the sage testsuite), it can't hurt to backport the fixalready.Upstream:matplotlib/matplotlib#12478
timokau added a commit to NixOS/nixpkgs that referenced this pull requestFeb 11, 2019
* python.pkgs.matplotlib: add numpy 1.6 compat patchNumpy deprecated asscalar in 1.16. This will be fixed in the nextmatplotlib version, but to avoid deprecation warnings (and because theyare breaking the sage testsuite), it can't hurt to backport the fixalready.Upstream:matplotlib/matplotlib#12478* sage: add numpy 1.16 compatibility patchhttps://trac.sagemath.org/ticket/27000
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Small clean up to avoid deprecation warnings. Seenumpy/numpy#12123
PR Checklist