Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Update test images for new Ghostscript.#12366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:masterfromQuLogic:update-images
Oct 3, 2018

Conversation

QuLogic
Copy link
Member

PR Summary

These are created using 9.24; just trying to see if that's what will fix it.@jklymak says Travis is now on 9.25. If this works, we should probably add some tolerances for old versions.

PR Checklist

  • Has Pytest style unit tests
  • [N/A] Code isFlake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Copy link
MemberAuthor

OK, even though I replaced the image,test_boxplot[pdf] is still failing. It also fails locally too.

I also don't understand whyhatch_simplify seems to have gotten thicker lines but this never failed before.

@QuLogic
Copy link
MemberAuthor

Sohatch_simplify.pdf hasn't been changed since 2015, but in fact it should have changed with#6198 which unified the width of hatch lines across formats. Due to buggy Ghostscript I guess, this was never done.

@QuLogicQuLogicforce-pushed theupdate-images branch 2 times, most recently fromf98eb5e to0b34cb7CompareOctober 2, 2018 08:26
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems ready to go - should it still be WIP?

@QuLogic
Copy link
MemberAuthor

Possibly. Can someone who has an older ghostscript try it out to see if we need any higher tolerances for them?

@QuLogicQuLogic added this to thev3.0.x milestoneOct 3, 2018
@QuLogic
Copy link
MemberAuthor

In the interest of getting CI working, I'm going to merge this. If anyone has any problems, please open a PR with increased tolerance.

@QuLogicQuLogic merged commit46ba49a intomatplotlib:masterOct 3, 2018
@QuLogicQuLogic deleted the update-images branchOctober 3, 2018 08:17
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 3, 2018
@timhoffm
Copy link
Member

FYI: This works with ghostscript 9.19.

@QuLogic
Copy link
MemberAuthor

Ah, good to know.

dstansby added a commit that referenced this pull requestOct 3, 2018
…366-on-v3.0.xBackport PR#12366 on branch v3.0.x (TST: Update test images for new Ghostscript.)
@jklymak
Copy link
Member

@meeseeksdev backport to v3.0.0-doc

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 5, 2018
jklymak added a commit that referenced this pull requestOct 5, 2018
…366-on-v3.0.0-docBackport PR#12366 on branch v3.0.0-doc (TST: Update test images for new Ghostscript.)
@QuLogic
Copy link
MemberAuthor

@meeseeksdev backport to v2.2.x

@QuLogicQuLogic modified the milestones:v3.0.x,v2.2.4Oct 12, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 12, 2018
QuLogic added a commit that referenced this pull requestOct 13, 2018
…366-on-v2.2.xBackport PR#12366 on branch v2.2.x (TST: Update test images for new Ghostscript.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v2.2.4
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@timhoffm@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp