Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix some warnings from Travis#12316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approved, subject to CI.
Looks like alot more are triggered in AppVeyor. I will try to get to those later today. |
7877939
to8942b07
CompareManaged to fix up a few more sets, from AppVeyor and macOS, due to missing dependencies triggering warnings in the checks. |
Using pytest.param(..., marks=pytest.mark.something) is a different typethan if using pytest.mark.something(...), so we need to handle that caseon skipping extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for catching the other parameterise fixes!
@meesekesdev backport to v3.0.x |
Note that since this would use |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
These are pretty much deprecated items in our dependencies. Slightly related to#12297.
PR Checklist