Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[DO NO MERGE] Remove deprecated OSX checks#12252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Okay, so it turns out that this doesn't error properly on non-framework versions of python, so it looks like the check relies on trying to spawn a process using |
For anyone following, it looks like we need to replace the lines I deleted with something fromhttps://developer.apple.com/documentation/appkit/nsrunningapplication |
I assume there is some way to pick the code path based on the version of osx? |
Yes, there's some version checks at the top of the file that I think would work. |
Do we have a lowest-supported-version of OSX? |
We should be pretty not-aggressive about a minimum osx version. If you can get python 3.5 to run on it we should support it. |
Closing in lieu of#12603 which now goes back to using the more modern checks... |
(at least locally) thisfixes#12188 . All I have done is get rid of two deprecated functions,
GetCurrentProcess, andSetFrontProcess. This seems to stop the bouncing. I guess that these need to be replaced with their modern alternatives, but I can't work out what they should be...