Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make boilerplate-generated pyplot.py flake8 compliant#12236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tools/boilerplate.py Outdated
| # Autogenerated by boilerplate.py. Do not edit as changes will be lost.""" | ||
| CMAPPABLE_TEMPLATE = AUTOGEN_MSG + """ | ||
| CMAPPABLE_TEMPLATE =AUTOGEN_MSG + """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why'd we pick up a space here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, typo.
4abab3d tof8f8b2bCompareOwee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
…v3.0.xBackport PR#12236 on branch v3.0.x
PR Summary
This does two things:
# noqato lines likeif isinstance(__ret, cm.ScalarMappable): sci(__ret).flake 8 complains that this should be wrapped (E701). However that's cumbersome to get a correct indentation. Since these are just 5 cases and it's in autogenerated code, which likely nobody will read anyway, I prefer the explicit exclusion of these lines compared to deactivating E701 for the whole file.
PR Checklist