Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: pcolor/pcolormesh honour edgecolors kwarg when facecolors is set 'none'#12226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pharshalp wants to merge1 commit intomatplotlib:masterfrompharshalp:fix_pcolor_pcolormesh_edgecolor
Closed

FIX: pcolor/pcolormesh honour edgecolors kwarg when facecolors is set 'none'#12226

pharshalp wants to merge1 commit intomatplotlib:masterfrompharshalp:fix_pcolor_pcolormesh_edgecolor

Conversation

pharshalp
Copy link
Contributor

@pharshalppharshalp commentedSep 23, 2018•
edited
Loading

PR Summary

Closes#1302

This fixes the issue#1302 [edgecolor(s) being ignored by pcolor/pcolormesh when facecolor(s) is set to 'none'].

From a quick look at the discussion in#1302 and looking at the underlying code, I think this PR should work.NOTE: I am not entirely familiar with how the Collection object is supposed to behave. If this PR fails the tests then I will close this PR and dig deeper to find the correct approach. (all the tests passed!).

Example:

importmatplotlib.pyplotaspltimportnumpyasnpplt.pcolor(np.arange(12).reshape(4,3),edgecolors='red',facecolors='none')plt.show()

Current outcome:
test

Correct outcome (after applying the fix in this PR):
test1

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [ ] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@pharshalppharshalp changed the title[WIP] pcolor/pcolormesh bug #1302 (edgecolors being ignored by pcolor/pcolormesh when facecolors is set 'none').pcolor/pcolormesh bug #1302 (edgecolors being ignored by pcolor/pcolormesh when facecolors is set 'none').Sep 23, 2018
@pharshalppharshalp changed the titlepcolor/pcolormesh bug #1302 (edgecolors being ignored by pcolor/pcolormesh when facecolors is set 'none').pcolor/pcolormesh bug #1302 (edgecolors being ignored when facecolors is set 'none').Sep 23, 2018
@pharshalppharshalp changed the titlepcolor/pcolormesh bug #1302 (edgecolors being ignored when facecolors is set 'none').Fixes #1302 (pcolor/pcolormesh bug - edgecolors being ignored when facecolors is set 'none').Sep 23, 2018
@dopplershift
Copy link
Contributor

Would you be able to turn your example code above into an image test so that we don't break this in the future?

pharshalp reacted with thumbs up emoji

@jklymak
Copy link
Member

@pharslap, looks great. I took the liberty of editing your title - no need to ref original issue, and description of fix is most helpful...

pharshalp reacted with thumbs up emoji

@jklymakjklymak changed the titleFixes #1302 (pcolor/pcolormesh bug - edgecolors being ignored when facecolors is set 'none').FIX: pcolor/pcolormesh honour edgecolors kwarg when facecolors is set 'none'Sep 23, 2018
@pharshalp
Copy link
ContributorAuthor

Would you be able to turn your example code above into an image test so that we don't break this in the future?

@dopplershift I have added a test that doesn't use image comparison.

@dstansbydstansby added this to thev3.1 milestoneSep 24, 2018
@pharshalp
Copy link
ContributorAuthor

@WeatherGod@efiring Could you please take a look at this? Tagging you since you were involved in the discussion on the issue. Thanks!

@efiring
Copy link
Member

I'm pretty sure this is not the right solution. It looks like there is a simple underlying bug that this is not addressing. Investigating...

@pharshalp
Copy link
ContributorAuthor

I'm pretty sure this is not the right solution. It looks like there is a simple underlying bug that this is not addressing. Investigating...

Ok. Thanks for taking a look!

@jklymak
Copy link
Member

@efiring - still investigation 😉 I'll assume this can wait for 3.2...

@jklymakjklymak modified the milestones:v3.1.0,v3.2.0Feb 26, 2019
@efiringefiring self-assigned thisMay 23, 2019
@tacaswelltacaswell modified the milestones:v3.2.0,v3.3.0Sep 5, 2019
@QuLogicQuLogic modified the milestones:v3.3.0,v3.4.0May 2, 2020
@efiring
Copy link
Member

Sorry for the long delay. I will try to take care of this as soon as#6268 goes in.

@efiring
Copy link
Member

This is superseded by#18480. Thank you for the contribution,@pharshalp. Although your PR was not merged, it led to a different solution to the problem.

pharshalp reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

Assignees

@efiringefiring

Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

pcolormesh bug: edgecolor ignored
7 participants
@pharshalp@dopplershift@jklymak@efiring@tacaswell@QuLogic@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp