Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve docstring of Annotation#12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

PR Summary

As part of#10148: Docstring update forAnnotation.

@timhoffmtimhoffm added this to thev3.0.x milestoneSep 22, 2018
`~matplotlib.backend_bases.RendererBase` object as input
and return a `~matplotlib.transforms.Transform` or
`~matplotlib.transforms.Bbox` object
where *render* is a `.RendererBase` subclass.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

renderer

@ImportanceOfBeingErnest
Copy link
Member

Annotation has propertiesanncoords andxyann which do not have any docstring. Not sure if this shall be part of this PR, but it would be good to document those.

@timhoffmtimhoffmforce-pushed thedoc-annotate branch 2 times, most recently from97f91ff to66d787eCompareSeptember 23, 2018 08:49
@timhoffm
Copy link
MemberAuthor

I've added docstrings foranncoords andxyann. It's unfortunate that they have a different name than the corresponding constructor parameters. But that would be something for another PR.

@anntzer
Copy link
Contributor

See also#12144 re: mismatched names in constructor.

@ImportanceOfBeingErnest
Copy link
Member

I've added docstrings for anncoords and xyann.

I don't see any change to the previous version.
image

@timhoffmtimhoffmforce-pushed thedoc-annotate branch 3 times, most recently from25ca6ee to8bb39f5CompareSeptember 24, 2018 18:46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All comments handled.

@ImportanceOfBeingErnestImportanceOfBeingErnest merged commit7bcf618 intomatplotlib:masterSep 30, 2018
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7bcf6186e9420608ab60ea36b76f9a295aa4ea8a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12214: Improve docstring of Annoation'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-12214-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR#12214 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

ImportanceOfBeingErnest added a commit to ImportanceOfBeingErnest/matplotlib that referenced this pull requestSep 30, 2018
@ImportanceOfBeingErnest
Copy link
Member

This was tagged with v3.0.x. So when merging, it tried to autobackport to that branch. I resolved the conflict (which was a single empty line (??)), and created#12214, but does this now still need to go to v3.0.0-doc? Should it have been tagged with v3.0.0-doc instead?

@QuLogic
Copy link
Member

Changes in.py files do not belong on the-doc branches as they have no effect on the resulting doc rebuilds.

@timhoffmtimhoffm deleted the doc-annotate branchOctober 1, 2018 05:52
dstansby added a commit that referenced this pull requestOct 1, 2018
@QuLogicQuLogic changed the titleImprove docstring of AnnoationImprove docstring of AnnotationApr 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ImportanceOfBeingErnestImportanceOfBeingErnestImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.

5 participants
@timhoffm@ImportanceOfBeingErnest@anntzer@QuLogic@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp