Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: don't check for interactive framework if none required#12207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
QuLogic merged 1 commit intomatplotlib:masterfromjklymak:fix-dont-check-framework-non-guiSep 23, 2018
Merged
FIX: don't check for interactive framework if none required#12207
QuLogic merged 1 commit intomatplotlib:masterfromjklymak:fix-dont-check-framework-non-guiSep 23, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Looks fine, though I have no idea whether that helps with the issue or not. |
tacaswell approved these changesSep 22, 2018
It stops instantiating macOSx framework if no framework is required. |
QuLogic approved these changesSep 23, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 23, 2018
…ork if none required
dstansby added a commit that referenced this pull requestSep 23, 2018
…207-on-v3.0.xBackport PR#12207 on branch v3.0.x (FIX: dont' check for interactive framework if none required)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Closes#12188
Don't check the interactive framework if none is required...
Still tries the framework if a GUI is required, so pythons that pop up a GUI when the framework is started (i.e. OSX Framework builds) will pop up a gui when pyplot is imported.
PR Checklist