Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document legend's slowness when "best" location is used#12203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kbrose
Copy link
Contributor

PR Summary

Document the slowness of legend's default axis behavior with large amounts of data. Ref#12120.

PR Checklist

  • Documentation is sphinx and numpydoc compliant

p.s. Congrats on 3.0!

@kbrose
Copy link
ContributorAuthor

For "Documentation is sphinx and numpydoc compliant" is there a way I can verify that? Do the circle CI runs check that? Maybe there will be a build of the docs I could look at to make sure it looks correct?

@jklymak
Copy link
Member

You can check the output in the CircleCI logs for the location of the built documentation, follow that link and see that it looks OK.

kbrose reacted with thumbs up emoji

@ImportanceOfBeingErnest
Copy link
Member

The documentation build of your PR is available athttps://circleci.com/gh/matplotlib/matplotlib/13683/artifacts/0//home/circleci/project/doc/build/html/index.html You find this link via he "Details"-Button on the checks.

kbrose reacted with thumbs up emoji

@ImportanceOfBeingErnest
Copy link
Member

ImportanceOfBeingErnest commentedSep 21, 2018
edited
Loading

This is only a minor point, but in general the documentation mostly uses a passive style, like "A parameter can be set." instead of "You may set a parameter."
I don't think this is relevant for the tutorial, where "you" is also used at other places, but for the docstring itself?

@kbrose
Copy link
ContributorAuthor

Should I change to passive? I thought it may be but I did a ctrl-f "you" inhttps://matplotlib.org/users/legend_guide.html and found examples so I thought it'd be fine.

@jklymak
Copy link
Member

My vote is for active voice most of the time.

@ImportanceOfBeingErnest
Copy link
Member

Nevermind, even theAxes.legend docstring addressed the reader in person before this change.

@ImportanceOfBeingErnestImportanceOfBeingErnest merged commit098b865 intomatplotlib:masterSep 21, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 21, 2018
@kbrosekbrose deleted the document-legend-best-slowness branchSeptember 21, 2018 18:54
QuLogic added a commit that referenced this pull requestSep 21, 2018
…203-on-v3.0.xBackport PR#12203 on branch v3.0.x (Document legend best slowness)
@kbrosekbrose changed the titleDocument legend best slownessDocument legend's slowness when "best" location is usedSep 28, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@ImportanceOfBeingErnestImportanceOfBeingErnestImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.

3 participants
@kbrose@jklymak@ImportanceOfBeingErnest

[8]ページ先頭

©2009-2025 Movatter.jp