Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: colorbar re-check norm before draw for autolabels#12159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

closes#12155

If a user changes the norm on a colorbar from a linear to logarithmic, we were not changing the scale of the colorbar axes to a logarithmic scale. That needs to be done after#9903 because we now use normal locators for colorbar axes.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak added this to thev3.0.x milestoneSep 18, 2018
@ImportanceOfBeingErnest
Copy link
Member

Ifconfig_axis is now called withindraw_all, one can get rid of it inside of__init__

self.config_axis()
self.draw_all()

andupdate_bruteforce I guess

self.config_axis()
self.draw_all()

jklymak reacted with thumbs up emoji

@jklymakjklymakforce-pushed thefix-check-norm-autolabels branch 2 times, most recently from0efbd3a toe10954cCompareSeptember 19, 2018 02:30
@jklymakjklymakforce-pushed thefix-check-norm-autolabels branch 2 times, most recently frome891183 to6e34845CompareSeptember 20, 2018 17:53
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

modulo a rebase and tests passing.

@jklymakjklymakforce-pushed thefix-check-norm-autolabels branch 2 times, most recently fromcda498c toa4e33cfCompareOctober 15, 2018 19:47
FIX: properly set x/y limitsMNT: add tolerance to colorbar locator methods
@jklymakjklymakforce-pushed thefix-check-norm-autolabels branch froma4e33cf to3add532CompareOctober 15, 2018 20:02
@dstansbydstansby merged commit97a580c intomatplotlib:masterOct 17, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 17, 2018
dstansby added a commit that referenced this pull requestOct 17, 2018
…159-on-v3.0.xBackport PR#12159 on branch v3.0.x (FIX: colorbar re-check norm before draw for autolabels)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@dstansbydstansbydstansby approved these changes

@efiringefiringAwaiting requested review from efiring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.

Incorrect placement of Colorbar ticks using LogNorm
4 participants
@jklymak@ImportanceOfBeingErnest@tacaswell@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp