Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Deprecate \stackrel.#12150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:stackrel
Feb 22, 2019
Merged

Deprecate \stackrel.#12150

jklymak merged 1 commit intomatplotlib:masterfromanntzer:stackrel
Feb 22, 2019

Conversation

anntzer
Copy link
Contributor

Mathtext's \stackrel{a}{b} behaves subtly differently from latex's
\stackrel{a}{b}: mathtext makesa andb equal-sized whereas latex
makesa smaller thanb (a is an "annotation" overb). Given
that we can already stack expressions using the (admittedly less
practical, but standard) \genfrac, just deprecate \stackrel instead of
maintaining our own latex-like dialect.

Also undeprecate passing obj_type to the cbook.deprecated decorator(!),
given that this PR has a good reason to use it... and while we're at it,
reorder the kwargs docs for cbook.deprecated and cbook.warn_deprecated
to match the order in the signature.

Again related to#12108 /#12128 (:mathmpl: still exists because mathtext is subtly different from latex).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswelltacaswell added this to thev3.1 milestoneSep 18, 2018
@anntzeranntzerforce-pushed thestackrel branch 2 times, most recently from90b3bc1 tocec36cdCompareOctober 5, 2018 14:17
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fine w/ me. Doubt this is the most heavily used corner of the codebase...

@anntzer
Copy link
ContributorAuthor

rebased

Mathtext's \stackrel{a}{b} behaves subtly differently from latex's\stackrel{a}{b}: mathtext makes `a` and `b` equal-sized whereas latexmakes `a` smaller than `b` (`a` is an "annotation" over `b`).  Giventhat we can already stack expressions using the (admittedly lesspractical, but standard) \genfrac, just deprecate \stackrel instead ofmaintaining our own latex-like dialect.Also undeprecate passing obj_type to the cbook.deprecated decorator(!),given that this PR has a good reason to use it... and while we're at it,reorder the kwargs docs for cbook.deprecated and cbook.warn_deprecatedto match the order in the signature.
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Subject to CI pass.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Subject to CI pass.

@jklymak
Copy link
Member

CI failures unrelated...

@jklymakjklymak merged commit977f415 intomatplotlib:masterFeb 22, 2019
@anntzeranntzer deleted the stackrel branchFebruary 22, 2019 22:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@jklymak@timhoffm@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp