Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Mathtext tutorial fixes#12149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Mathtext tutorial fixes#12149
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fc588cc tob15a24eCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
I've added some oxford commas and capitalization of Matplotlib. Will merge once the CI passes!
yay, to, oxford, commas, |
tutorials/text/mathtext.py Outdated
| Fractions, binomials and stacked numbers can be created with the ``\frac{}{}``, | ||
| Fractions, binomials, and stacked numbers can be created with the ``\frac{}{}``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Line too long with the comma 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm now wondering if I should use the github interface or give up on being lazy and clone the code…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
decision postponed after the coffee break ☕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
- Remove reference to (obsolete) narrow python builds.- Quote a string.
- Switch from part-string, part-comment to a single large string.- Reflow to 79 characters wide.
…149-on-v3.0.xBackport PR#12149 on branch v3.0.x (Mathtext tutorial fixes)
…149-on-v3.0.0-docBackport PR#12149 on branch v3.0.0-doc (Mathtext tutorial fixes)
Mathtext tutorial fixesConflicts:.flake8 - does not exist on this branchtutorials/text/mathtext.py - keep all backported changes
PR Summary
I'd suggest reviewing the two commits separately :p
Preliminary work to a proper fix of#12108 /#12128
PR Checklist