Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add explicit getters and setters for Annotation.anncoords.#12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:anncoords-getset
Sep 18, 2018

Conversation

anntzer
Copy link
Contributor

While we may, in some distant future, move to properties everywhere,
right now providing getters and setters allows for uniform code for
touching Artist properties.


  • I have a real use case in mplcursors for this feature :) (in the sense that it avoids some more hardcoding that anncoords are "special" as they are directly assigned instead of going through a setter).
  • I did not add getters and setters for xyann because they already have get_position/set_position.
  • InAnnotation refactor #2351@tacaswell renamed what was before thetextcoords attribute toanncoords, but the keyword argument to the Annotation constructor was not changed (so it's stilltextcoords). I'd suggest renaming the constructor argument for consistency...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

While we may, in some distant future, move to properties everywhere,right now providing getters and setters allows for uniform code fortouching Artist properties.
@anntzeranntzer added this to thev3.1 milestoneSep 17, 2018
@timhoffmtimhoffm merged commit521b60a intomatplotlib:masterSep 18, 2018
@anntzeranntzer deleted the anncoords-getset branchSeptember 18, 2018 18:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@jklymak@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp