Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Unbreak formlayout for image edits.#12142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:formlayout
Sep 17, 2018

Conversation

anntzer
Copy link
Contributor

As of master, the qt editor is broken when editing an axes that contains
an image throws an error when clicking OK. This is becauseself.data
needs to be modifiedin-place in FormWidget.setup, as FormWidget.get
later checks some explicit types in there.

This means, as a side note, that passing a tuple instead of a list to
generate a QComboBox is broken (one can test that by modifying the
example at the bottom of the module -- the results are different
depending on whether 'list2' is a list or a tuple) but that's something
we can deal with some other day...

Partial revert of#11684 (well, I naively assumed that the base code was
correct...).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

As of master, the qt editor is broken when editing an axes that containsan image throws an error when clicking OK.  This is because `self.data`needs to be modified *in-place* in FormWidget.setup, as FormWidget.getlater checks some explicit types in there.This means, as a side note, that passing a tuple instead of a list togenerate a QComboBox is broken (one can test that by modifying theexample at the bottom of the module -- the results are differentdepending on whether 'list2' is a list or a tuple) but that's somethingwe can deal with some other day...
@anntzeranntzer added this to thev3.0 milestoneSep 17, 2018
@anntzeranntzer added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelSep 17, 2018
@tacaswelltacaswell merged commitef04ad9 intomatplotlib:masterSep 17, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 17, 2018
@anntzeranntzer deleted the formlayout branchSeptember 17, 2018 16:21
tacaswell added a commit that referenced this pull requestSep 17, 2018
…142-on-v3.0.xBackport PR#12142 on branch v3.0.x (Unbreak formlayout for image edits.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp