Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Mention colorbar.minorticks_on/off in references#12130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfrompharshalp:fix_example_colorbar_basics
Sep 15, 2018
Merged

Mention colorbar.minorticks_on/off in references#12130

tacaswell merged 1 commit intomatplotlib:masterfrompharshalp:fix_example_colorbar_basics
Sep 15, 2018

Conversation

pharshalp
Copy link
Contributor

@pharshalppharshalp commentedSep 15, 2018•
edited
Loading

PR Summary

I forgot to mention the newly introduced (#11584) colorbar.minorticks_on/off method in the references for the example.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
Copy link
Member

Thanks for the diligence in documentation, however the referneces do not seem to be quite right

Warning, treated as error:/home/circleci/project/examples/color/colorbar_basics.py failed to execute correctly: Traceback (most recent call last):  File "/home/circleci/project/examples/color/colorbar_basics.py", line 62, in <module>    matplotlib.pyplot.colorbar.minorticks_onAttributeError: 'function' object has no attribute 'minorticks_on'

Fixed incorrect reference to colorbar.minorticks_on/off
@pharshalp
Copy link
ContributorAuthor

pharshalp commentedSep 15, 2018•
edited
Loading

Thanks for the diligence in documentation, however the referneces do not seem to be quite right

Warning, treated as error:/home/circleci/project/examples/color/colorbar_basics.py failed to execute correctly: Traceback (most recent call last):  File "/home/circleci/project/examples/color/colorbar_basics.py", line 62, in <module>    matplotlib.pyplot.colorbar.minorticks_onAttributeError: 'function' object has no attribute 'minorticks_on'

@tacaswell thanks. (squashed and) pushed a fix.
Update: looks like it passes all the checks.

@tacaswelltacaswell merged commit68314b0 intomatplotlib:masterSep 15, 2018
@tacaswell
Copy link
Member

Thanks@pharshalp !

pharshalp reacted with thumbs up emoji

@pharshalppharshalp deleted the fix_example_colorbar_basics branchSeptember 15, 2018 22:32
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 15, 2018
tacaswell added a commit that referenced this pull requestSep 15, 2018
…130-on-v3.0.xBackport PR#12130 on branch v3.0.x (Mention colorbar.minorticks_on/off in references)
@pharshalppharshalp restored the fix_example_colorbar_basics branchSeptember 16, 2018 03:16
@pharshalppharshalp deleted the fix_example_colorbar_basics branchSeptember 16, 2018 03:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@pharshalp@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp