Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.#12128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:sphinx18math
Sep 15, 2018

Conversation

anntzer
Copy link
Contributor

PR Summary

Would be kind of nice to have for 3.0, but heh.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.0 milestoneSep 15, 2018
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wow great. The only question I’d have is why we can’t use the Sphinx math directive, it I can believe they are different enough to make that a PITA

@anntzer
Copy link
ContributorAuthor

We can (and this PR basically does that implicitly by keeping :math: on the rest of the docs, which will use sphinx's math role),except for the mathtext tutorial because it uses mathtext construct that are not actually valid latex (\mathcircled,#7710 (comment)). My long term plan proposal is to rewrite the mathtext tutorial to just use the .. plot:: instead and completely kill :mathmpl: (even if you're using older versions of sphinx they also provide :math:, you just needed to add sphinx.ext.pngmath to the extensions list instead of being active by default).

This PR is just a stopgap fix.

jklymak reacted with thumbs up emoji

@tacaswelltacaswell merged commit2188358 intomatplotlib:masterSep 15, 2018
@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

@anntzeranntzer deleted the sphinx18math branchSeptember 15, 2018 18:45
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestSep 15, 2018
FIX: Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.
This was referencedSep 18, 2018
@ImportanceOfBeingErnest
Copy link
Member

ImportanceOfBeingErnest commentedSep 19, 2018•
edited
Loading

In theWriting mathematical expressions tutorial there are now strange red symbols appearing

image

image

which have not been there inthe previous version.

Is this a consequence of this PR?

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestFeb 12, 2019
FIX: Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.Conflicts:lib/matplotlib/sphinxext/mathmpl.py          - import cleanups
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@ImportanceOfBeingErnest@jklymak@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp