Sep 15, 2018 · Sep 11, 2018 · Sep 12, 2018 · Sep 12, 2018 · Sep 12, 2018 · Sep 12, 2018
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
        vmin = self._colorbar.norm.vmin
        vmax = self._colorbar.norm.vmax
        ticks = ticker.AutoMinorLocator.__call__(self)
        return ticks[(ticks >= vmin) & (ticks <= vmax)]
        rtol = (vmax - vmin) * 1e-10
        return ticks[(ticks >= vmin - rtol) & (ticks <= vmax + rtol)]


 class _ColorbarLogLocator(ticker.LogLocator):
diff --git a/lib/matplotlib/tests/test_colorbar.py b/lib/matplotlib/tests/test_colorbar.py
        np.testing.assert_almost_equal(cbar.ax.yaxis.get_minorticklocs(),
                                       np.array([]))

        im.set_clim(vmin=-1.2, vmax=1.2)
        cbar.minorticks_on()
        correct_minorticklocs = np.array([-1.2, -1.1, -0.9, -0.8, -0.7, -0.6,
                                          -0.4, -0.3, -0.2, -0.1,  0.1, 0.2,
                                           0.3,  0.4,  0.6,  0.7,  0.8,  0.9,
                                           1.1,  1.2])
        np.testing.assert_almost_equal(cbar.ax.yaxis.get_minorticklocs(),
                                       correct_minorticklocs)


 def test_colorbar_autoticks():
    # Test new autotick modes. Needs to be classic because
Original file line number	Diff line number	Diff line change
Expand Up		@@ -267,7 +267,8 @@ def __call__(self):
		vmin = self._colorbar.norm.vmin
		vmax = self._colorbar.norm.vmax
		ticks = ticker.AutoMinorLocator.__call__(self)
		return ticks[(ticks >= vmin) & (ticks <= vmax)]
		rtol = (vmax - vmin) * 1e-10
		return ticks[(ticks >= vmin - rtol) & (ticks <= vmax + rtol)]
Copy link Member timhoffmSep 12, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Just as a thought: Can it happen, that vmin > vmax? If so, neither the original nor the fixed code would work in that case. Copy link MemberAuthor jklymakSep 12, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yes but that gets checked and swapped inside the method before this code Copy link MemberAuthor jklymakSep 12, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Confirmed that vmax and vmin get flipped if they are specified out of order. Which maybe is bad behaviour? But its what colorbar does...


		class _ColorbarLogLocator(ticker.LogLocator):
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -294,6 +294,15 @@ def test_colorbar_minorticks_on_off():
		np.testing.assert_almost_equal(cbar.ax.yaxis.get_minorticklocs(),
		np.array([]))

		im.set_clim(vmin=-1.2, vmax=1.2)
		cbar.minorticks_on()
		correct_minorticklocs = np.array([-1.2, -1.1, -0.9, -0.8, -0.7, -0.6,
		-0.4, -0.3, -0.2, -0.1, 0.1, 0.2,
		0.3, 0.4, 0.6, 0.7, 0.8, 0.9,
		1.1, 1.2])
		np.testing.assert_almost_equal(cbar.ax.yaxis.get_minorticklocs(),
		correct_minorticklocs)


		def test_colorbar_autoticks():
		# Test new autotick modes. Needs to be classic because
Expand Down