Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update backend_qt5agg to fix PySide2 mem issues#12092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromsimon-kraeusel:fix-issue-12089
Sep 11, 2018

Conversation

simon-kraeusel
Copy link
Contributor

@simon-kraeuselsimon-kraeusel commentedSep 11, 2018•
edited by jklymak
Loading

Pyside2 seems to have the same issue as PySide where the QImage data reference is incorrect and needs to be adjusted for the Python garbage collector.

Closes#12089

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Pyside2 seems to have the same issue as PySide where the QImage data reference is incorrect and needs to be adjusted for the Python garbage collector.
@jklymakjklymak added this to thev2.2.4 milestoneSep 11, 2018
@jklymakjklymak merged commit603b4fa intomatplotlib:masterSep 11, 2018
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 603b4faf539531a6a02933a4ef7369f4c860dead
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12092: Update backend_qt5agg to fix PySide2 mem issues'
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-12092-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR#12092 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 11, 2018
jklymak added a commit to jklymak/matplotlib that referenced this pull requestSep 11, 2018
jklymak added a commit that referenced this pull requestSep 11, 2018
…092-on-v3.0.xBackport PR#12092 on branch v3.0.x (Update backend_qt5agg to fix PySide2 mem issues)
anntzer added a commit that referenced this pull requestSep 11, 2018
…2.2.xBackport PR#12092: Update backend_qt5agg to fix PySide2 mem issues
@tacaswell
Copy link
Member

Thanks@simon-kraeusel !

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.4
Development

Successfully merging this pull request may close these issues.

PySide2 memory leak during canvas paintEvent
4 participants
@simon-kraeusel@tacaswell@anntzer@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp