NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

FIX: make MaxNLocator only follow visible ticks for order of magnitude#12086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

NelleV merged 2 commits intomatplotlib:masterfromjklymak:fix-changing-orderofmagnitude

Sep 14, 2018

Merged

FIX: make MaxNLocator only follow visible ticks for order of magnitude#12086

NelleV merged 2 commits intomatplotlib:masterfromjklymak:fix-changing-orderofmagnitude

Sep 14, 2018

Conversation

Copy link

Member

PR Summary

Closes#12072

Order of magnitude for tick formatting in ScalarFormatter was using invisible ticks. This changes to just use visible.

Probably obviated by#11004 but won't hurt anything.

Before:

After

Code

importmatplotlib.pyplotaspltimportmatplotlib.tickerastickersci_nums= [10**9,8*10**9]plt.rcParams['ytick.labelsize']=13fig,ax=plt.subplots(1,2)ax[0].scatter(range(len(sci_nums)),sci_nums)ax[1].scatter(range(len(sci_nums)),sci_nums)ax[1].yaxis.set_major_locator(ticker.MaxNLocator(4))plt.show()

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link

Member

QuLogic commentedSep 11, 2018

Seems to have broken some docs when there are no visible ticks.

Copy link

MemberAuthor

jklymak commentedSep 11, 2018

Ha, it passes all oftest_axes andtest_ticker...

FIX: make MaxNLocator only follow visible ticks for order of magnitude

ed1c830

jklymak force-pushed thefix-changing-orderofmagnitude branch fromfc00626 toed1c830Compare

September 11, 2018 00:12

anntzer approved these changes

Sep 11, 2018

View reviewed changes

Copy link

Contributor

@anntzer I think the docs are OK (they say it'll just key off the data, not the data plus one tick on either side). It does need tests, which I'll do now. I actually don't understand whytest_ticker passes all the tests... It should have failed some of them. Of course the test for this is all parameterized etc, so it'll take me a bit to grok what is going on..