NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Speed up canvas redraw for GTK3Agg backend.#12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 2 commits intomatplotlib:masterfromakhilman:speed-up-gtk3agg-redraw

Sep 19, 2018

Merged

Speed up canvas redraw for GTK3Agg backend.#12030

QuLogic merged 2 commits intomatplotlib:masterfromakhilman:speed-up-gtk3agg-redraw

Sep 19, 2018

Conversation

Copy link

Contributor

akhilman commentedSep 6, 2018

PR Summary

Move_render_figure() call out ofon_draw_event handler
inFigureCanvasGTK3Agg class and call it from overloaded
draw() method.
Fixes#12010

Gtk triggersdraw event not only when actual plot redraw
required but also when any another widget drawn over canvas.
This makes application with embided plot unresponsive in cases
when popover or popup menu are drawn over plot.
You may try example provided in#12010.

Moving actual plot redraw out ofon_draw_event() makes GUI
much more responsive.

This changes tested with:

animation from examples/ directory
interacive pan and zoom
cursor widget with bliting
calling draw_idle() to update interactive chart

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Speed up canvas redraw for GTK3Agg backend.

b18a576

Move `_render_figure()` call out of `on_draw_event` handlerin `FigureCanvasGTK3Agg` class and call it from overloaded`draw()` method.Fixes#12010Gtk triggers `draw` event not only when actual plot redrawrequired but also when any another widget drawn over canvas.This makes application with embided plot unresponsive in caseswhen popover or popup menu are drawn over plot.You may try example provided in#12010.Moving actual plot redraw out of `on_draw_event()` makes GUImuch more responsive.This changes tested with:* animation from examples/ directory* interacive pan and zoom* cursor widget with bliting* calling draw_idle() to update interactive chart