Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix AttributeError in GTK3Agg backend#12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromakhilman:fix-gtk3agg-attribute-error
Sep 5, 2018
Merged

Fix AttributeError in GTK3Agg backend#12016

timhoffm merged 1 commit intomatplotlib:masterfromakhilman:fix-gtk3agg-attribute-error
Sep 5, 2018

Conversation

akhilman
Copy link
Contributor

Fixes#12015

PR Summary

backend_cairo has not_unmultipled_rgba8888_to_premultiplied_argb32 attribute, butcbook does.
Examples doesn't work without this patch, but works well with it.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, and congratulation to your first contribution to matplotlib!

@timhoffm
Copy link
Member

Regression from#11845.

@timhoffmtimhoffm added this to thev3.0 milestoneSep 5, 2018
@timhoffmtimhoffm added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelSep 5, 2018
@timhoffmtimhoffm merged commit248399e intomatplotlib:masterSep 5, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 5, 2018
@anntzer
Copy link
Contributor

anntzer commentedSep 5, 2018•
edited
Loading

Now the real question is why flake8 didn't catch this...
I guess it doesn't check for names defined in other modules?

@anntzeranntzer mentioned this pull requestSep 5, 2018
6 tasks
dstansby added a commit that referenced this pull requestSep 5, 2018
…016-on-v3.0.xBackport PR#12016 on branch v3.0.x (Fix AttributeError in GTK3Agg backend)
@akhilmanakhilman deleted the fix-gtk3agg-attribute-error branchSeptember 5, 2018 12:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

AttributeError with GTK3Agg backend
4 participants
@akhilman@timhoffm@anntzer@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp