Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: fallback text renderer to fig._cachedRenderer, if none found#12012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Milestoning for backporting, because this actually fixes a regression... |
anntzer commentedSep 5, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I guess this runs afoul of#11971 (comment), but OTOH I can't think of anything better right now. |
…hedRenderer, if none found
…hedRenderer, if none found
…012-on-v2.2.xBackport PR#12012 on branch v2.2.x (FIX: fallback text renderer to fig._cachedRenderer, if none found)
…012-on-v3.0.xBackport PR#12012 on branch v3.0.x (FIX: fallback text renderer to fig._cachedRenderer, if none found)
PR Summary
Closes#10874. See also#11004, and#10881. This is a more general backstop than the ticking fixes being proposed in#10874.
If a text obejct is created, but never drawn, its renderer never gets set (
self._renderer
). Subsequnet calls toself.get_window_extent()
that do not specify the renderer fail withRuntimeError('Cannot get window extent w/o renderer')
.Here I propose that we fall back on the cached renderer for the figure.
Test code:
PR Checklist