Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Small bugfixes to the new pickle support.#1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -11,7 +11,11 @@ | |||
| import cPickle as pickle | |||
| #import pickle | |||
| from cStringIO import StringIO | |||
| import sys | |||
| if sys.version_info[0] >= 3: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've still not tested this, I took the lead frommathtext.py. Hopefully travis-ci will be helpful here.
travisbot commentedSep 2, 2012
So I had a python3 extension to fix test_pickle in this PR. My approach wasn't immediately successful so I backtracked and have simplified this PR to just make this critical pgf fix. Other PRs to follow. |
Small bugfixes to the new pickle support.
travisbot commentedSep 2, 2012
About that python3 test fix: The io module has been introduced in python 2.6, so the fix should be good for all supported versions. |
Pickling support (#1175) finally made it onto master. We merged early to avoid major conflicts with such a big PR, therefore this PR implements some of the identified issues.