NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Making it possible to use writer.setup kwargs from animation.save#11863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fredrik-1 wants to merge1 commit intomatplotlib:masterfromfredrik-1:anim_save_kwargs

Closed

Making it possible to use writer.setup kwargs from animation.save#11863

fredrik-1 wants to merge1 commit intomatplotlib:masterfromfredrik-1:anim_save_kwargs

Conversation

Copy link

Contributor

fredrik-1 commentedAug 16, 2018

This pr makes it possible to reach the additional kwargs in a writers setup method fromAnimation.save.

With this pr is it for example possible to write:

anim.save('anim.mp4', writer='ffmpeg_file', frame_prefix='_temporary_file', clear_temp=False)

dopplershift requested changes

Aug 16, 2018

View reviewed changes

Copy link

Contributor

dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 on the principle, just some doc wording changes.

lib/matplotlib/animation.py Outdated

		@@ -1060,6 +1060,9 @@ class to use, such as 'ffmpeg'. If ``None``, defaults to
		on to the `savefig` command which is called repeatedly to
		save the individual frames.

		**kwargs :
		Additional kwargs sendt to the writer's setup method.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"sendt" -> "to pass" ?

"writer's setup" ->writer.setup()?

making it possible to use writer.setup kwargs from animation.save

97c47b4

fredrik-1 force-pushed theanim_save_kwargs branch fromdc30bb4 to97c47b4Compare

August 19, 2018 10:42

Copy link

ContributorAuthor

fredrik-1 commentedAug 19, 2018

Made the changes and also made it possible to not explicitly usedpi when usingwriter.saving.

dstansby added the topic: animation label

Aug 27, 2018

Copy link

Contributor

Any progress on this? The inability to changeframe_prefix fromsave is causing problems when running multiple processes each callingsave. A process will then overwrite another process' temporary frame :(

Maybe I should submit a separate bug report about this particular issue..?

Copy link

Contributor

anntzer commentedJan 3, 2020

Really animation should write its tmpfiles to a tmpdir, see e.g.#3536 #11860, if you want to push either through...

anntzer mentioned this pull request

Jan 3, 2020

Default to writing animation frames to a temporary directory.#16082

Merged

6 tasks

Copy link

Member

jklymak commentedApr 15, 2021

I think this was closed by#16082, but feel free to request a re-open.

jklymak closed this

Apr 15, 2021

Copy link

Member

QuLogic commentedSep 14, 2024

I don't think this was actually closed by#16082. As noted in that PR, "the user can simply pass a non-Noneframe_prefix to write temporary frames wherever they want and keep them there." but there is no way to passframe_prefix without this PR, asframe_prefix is an argument toWriter.setup, which is called byAnimation.save, and not the user.

Unfortunately, I can't reopen this PR, and it probably needs a rebase, so I'll just open a new one.