Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make default arrow head width sensible#1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pelson merged 2 commits intomatplotlib:masterfromdmcdougall:arrow
Apr 2, 2013

Conversation

dmcdougall
Copy link
Member

Currently the default head width is too small to produce a visible arrow head by default, this explains the behaviour described in#1096. It is not the case that there is not enough information in the documentation to plot an arrow.

@travisbot
Copy link

This pull requestfails (mergedd636190 intocf7618c).

@pelson
Copy link
Member

What do these magic numbers mean? Why is 20 of them better than 3 of them? (other than experimental evidence)
Perhaps these magic numbers could be dropped into the rcParams?

This change will need an entry in the api changelog.

@dmcdougall
Copy link
MemberAuthor

Yes, so it's unclear. TheFancyArrow docstring is also not clear about what they are. The kwargwidth is the width of the arrow tail. Its default value is 0.001, but the docstring does not say what the units are. My first reaction was to say they in points, but I think thats too small. The kwarghead_width controls the width of the arrow head, its default is set to three times that ofwidth. This would mean the units are the same but, again, I don't know what they are.

@dmcdougall
Copy link
MemberAuthor

Would we prefer anrcParam for this instead? I'm starting to think that would be a better approach...

@pelson
Copy link
Member

Would we prefer an rcParam for this instead?

I'm not sure about this now. The scale factor is only used when a user hasn't specified an arrow width - if the user were looking to change this they should set the width directly rather than setting a scale factor indirectly inrcParams.

Personally I'd be happy to merge this if you wouldn't mind re-basing?

Currently the default head width is too small to produce a visible arrowhead by default, so make it bigger.
@dmcdougall
Copy link
MemberAuthor

Done.

@pelson
Copy link
Member

👍. Anybody else want to comment? If not, I'll merge in the next 48 hrs.

Cheers@dmcdougall

@dmcdougall
Copy link
MemberAuthor

@pelson Want to go ahead with this?

pelson added a commit that referenced this pull requestApr 2, 2013
Make default arrowhead width more sensible
@pelsonpelson merged commit6be9771 intomatplotlib:masterApr 2, 2013
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.x
Development

Successfully merging this pull request may close these issues.

3 participants
@dmcdougall@travisbot@pelson

[8]ページ先頭

©2009-2025 Movatter.jp