Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update vendored jquery#11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dstansby wants to merge2 commits intomatplotlib:masterfromdstansby:jquery
Closed

Conversation

dstansby
Copy link
Member

Simple fix for#11199, whilst#11246 is being discussed.

@dstansbydstansby added this to thev2.2.3 milestoneJul 24, 2018
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That basically defeats the point mentioned in#11199 (comment), repeated here for convenience:

Right now jquery weights 1.3Mb; compare this with the baseline test images that weight ~50Kb each and that we are painstakingly trying to avoid adding to the repo.

@dstansby
Copy link
MemberAuthor

Fair point, just to see what happens I've updated to the latest 1.x version in a way that should be a diff and not a file replace. I suspect the diff is still too large though.

@tacaswell
Copy link
Member

This missing a number of places the names need to be changed:

15:35 $ ack 'jquery-1.11'examples/user_interfaces/embedding_webagg_sgskip.py61:    <script src="_static/jquery/js/jquery-1.11.3.min.js"></script>doc/api/api_changes.rst1814:   +    <script src="_static/jquery/js/jquery-1.11.3.min.js"></script>lib/matplotlib.egg-info/SOURCES.txt1221:lib/matplotlib/backends/web_backend/jquery/js/jquery-1.11.3.js1222:lib/matplotlib/backends/web_backend/jquery/js/jquery-1.11.3.min.jslib/matplotlib/backends/web_backend/single_figure.html7:    <script src="{{ prefix }}/_static/jquery/js/jquery-1.11.3.min.js"></script>lib/matplotlib/backends/web_backend/all_figures.html7:    <script src="{{ prefix }}/_static/jquery/js/jquery-1.11.3.min.js"></script>

On the call we decided to go with this (despite the concerns about size) for expediency and trusting git's compression.

@tacaswell
Copy link
Member

We should also verify that this actually fixes the CVEs against jquery.

@efiring
Copy link
Member

I favor keeping the part of this PR that switches to using the unversioned name.

@tacaswell
Copy link
Member

We also need to update jquery-ui as that is what the CVE in#11199 is actually against.

@anntzer
Copy link
Contributor

Does this need to beurgently fixed? The CVE has been opened for more than 1y now, I don't see why this would have become urgent all of a sudden.
I can make#11246 work (as I said it's mostly there...), just notright now due to other priorities.

@tacaswelltacaswell modified the milestones:v2.2.3,v2.2.4Aug 5, 2018
@jklymakjklymak mentioned this pull requestSep 28, 2018
6 tasks
@dstansbydstansby mentioned this pull requestOct 14, 2018
@dstansby
Copy link
MemberAuthor

Yeah, replacing jquery-ui too makes this a bit of a large diff..

@tacaswell
Copy link
Member

Closing in favor of#11246

dstansby reacted with thumbs up emoji

@QuLogicQuLogic removed this from thev2.2.4 milestoneFeb 11, 2019
@dstansbydstansby deleted the jquery branchFebruary 11, 2019 08:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@dstansby@tacaswell@efiring@anntzer@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp