Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[wip] Add machinery to generate test-only wheels.#11732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Generate a matplotlib.tests wheel that can be uploaded to PyPI as aseparate PyPI package ("distribution", in distutils parlance), to makeit possible to install tests and test data from PyPI.This is useful e.g. for mplcairo, whose test suite relies onmatplotlib's one.power-cycled to run against current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems reasonable to me.
Needs some small additional changes to remove the tests from the default wheels and the configurability for that (so that the matplotlib.tests wheel doesn't overwrite stuff from the matplotlib wheel). |
anntzer commentedMar 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Probably needs a bit more wrangling with our handling of setup.cfg/MANIFEST.in so remilestoning... |
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
This will likely be superseded by the new work on testing machinery. |
Uh oh!
There was an error while loading.Please reload this page.
Generate a matplotlib.tests wheel that can be uploaded to PyPI as a
separate PyPI package ("distribution", in distutils parlance), to make
it possible to install tests and test data from PyPI.
This is useful e.g. for mplcairo, whose test suite relies on
matplotlib's one.
attn@tacaswell (I think I remember there were also some discussions re: installing test data or not for conda packages.)
Basically undoing#11055, but in a way that now works...
Would be nice to have for 3.0, but heh :)
As a side point, note that the 2.2.2 manylinux wheel currently on PyPI contains baseline images for mpl_toolkits, but not for matplotlib itself...
Edit: Looks like there can be funny issues if matplotlib is editably installed as this PR causes matplotlib.tests.egg-info to end up in lib, next to matplotlib.egg-info...
PR Summary
PR Checklist