Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: fix broken link in inset-locator example#11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromjklymak:doc-fix-broken-link-il
Jul 21, 2018

Conversation

jklymak
Copy link
Member

PR Summary

Made a small error in#11026 with resolving a link inexamples/axes_grid1/inset_locator_demo.py. I think this fixes it...

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak added this to thev3.0 milestoneJul 20, 2018
# optionally a location (loc) which accepts locations as codes, similar to
# `~matplotlib.axes.Axes.legend`.
# By default, the inset is offset by some points from the axes - this is
# The `.inset_locator`'s `~mpl_toolkits.axes_grid1.inset_axes` allows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If I'm not mistaken it should be
~mpl_toolkits.axes_grid1.inset_locator.inset_axes, which may probably be shortened to~inset_locator.inset_axes. So I guess I was the one to actually make this mistake when I last edited that example.

@jklymak
Copy link
MemberAuthor

It worked before because~.inset_axes was unique in the namespace, now there isAxes.inset_axes (on master).

@jklymakjklymakforce-pushed thedoc-fix-broken-link-il branch from19d8be7 to8661e9dCompareJuly 20, 2018 22:37
@ImportanceOfBeingErnest
Copy link
Member

...a quite unfortunate decision to name it exactly like the existing one.

@jklymak
Copy link
MemberAuthor

The end goal is to deprecate axes_grid1, so I’m not concerned about the method having the same name. Same thing happened w twinx.

@jklymakjklymakforce-pushed thedoc-fix-broken-link-il branch from8661e9d todec1c0eCompareJuly 21, 2018 04:57
@jklymak
Copy link
MemberAuthor

@dstansbydstansby merged commit38476fd intomatplotlib:masterJul 21, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ImportanceOfBeingErnestImportanceOfBeingErnestImportanceOfBeingErnest left review comments

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@jklymak@ImportanceOfBeingErnest@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp