NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

For property, use decorator or lambdas.#11698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:masterfromanntzer:propertydecorators

Aug 19, 2018

Merged

For property, use decorator or lambdas.#11698

jklymak merged 1 commit intomatplotlib:masterfromanntzer:propertydecorators

Aug 19, 2018

Conversation

Copy link

Contributor

anntzer commentedJul 18, 2018

Replace

def _get_foo(self): ...foo = property(_get_foo)

@propertydef foo(self): ...

foo = property(lambda self: ...)

(for the one-liner cases, when there are many of them, allowing to block
them together without blank lines in between).

Remove Affine2D.is_separable -- we can just inherit it from
Affine2DBase.is_separable.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

For property, use decorator or lambdas.

de28b4d

Replace```def _get_foo(self): ...foo = property(_get_foo)```by```@Propertydef foo(self): ...```or```foo = property(lambda self: ...)```(for the one-liner cases, when there are many of them, allowing to blockthem together without blank lines in between).Remove Affine2D.is_separable -- we can just inherit it fromAffine2DBase.is_separable.

anntzer force-pushed thepropertydecorators branch from707b8ba tode28b4dCompare

July 18, 2018 19:01