Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use super() instead of manually fetching supermethods for parasite axes.#11678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
(This manual fetching was previously done in _get_base_axes_attr.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good, apart from the "do not use" comment that should be clarified.
| @@ -224,13 +199,9 @@ def get_aux_axes(self, tr, viewlim_mode="equal", axes_class=None): | |||
| return ax2 | |||
| def _get_legend_handles(self, legend_handler_map=None): | |||
| # don't use this! | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jklymak You put this coment in last year. Why? Should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
#9324 (comment) Ithink the whole method should be removed, but maybe I'll put that in as a separate PR and not burden@anntzer with sorting out this stuff as part of an otherwise straightforward PR
PR Summary
This manual fetching was previously done in _get_base_axes_attr.
Second commit style-cleans the module.
PR Checklist