Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove some extra spaces in docstrings/comments.#11592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
.... I'm not going to ask how you found all these...
Merging because I don't think any code was touched... |
afvincent left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Huh, it looks like@jklymak was faster than I was ^^... I do not think that the two extra notes I have left are really worth it as the PR has already been merged: there are very (very) minor suggestions ;).
| @@ -2562,7 +2562,7 @@ def get_y(self): | |||
| return self._y | |||
| def get_width(self): | |||
| "Return the width of therectangle" | |||
| "Return the width of the rectangle" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Add a final period ? As you seem to have added it to other docstrings (at least one) 😈.
| @@ -1138,7 +1137,7 @@ def compute_geom_weights(self): | |||
| # In the below formula we could take modulo 2. but | |||
| # modulo 1. is safer regarding round-off errors (flat triangles). | |||
| angle = np.abs(np.mod((alpha2-alpha1) / np.pi, 1.)) | |||
| # Weight proportional to angle up np.pi/2; null weight for | |||
| # Weight proportional to angle up np.pi/2; null weight for | |||
| # degenerated cases 0. and np.pi (Note that `angle` is normalized | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Being there "degenerated cases 0 and np.pi (note thatangle is normalized"?
.... sorry |
@jklymak No problem 😄. (BTW, I would be interested to know how all those extra spaces were found ^^...) |
I noticed one while checking the signature of cbook.deprecated (for#11590). Then it just a matter of grepping for |
PR Summary
PR Checklist