Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Inline setup_external_compile into setupext.#11573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
setupext.py Outdated
| subprocess.check_call([os.path.abspath(cmdfile)], | ||
| ifplatform.architecture()[0]=='64bit': | ||
| WinXX=xXX='x64' | ||
| else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe just use.. = .. if platform.architecture()[0] else .. twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
setupext.py Outdated
| WinXX='Win32' | ||
| xXX='x86' | ||
| vcvarsall=msvc.find_vcvarsall(10.0) | ||
| ifvcvarsall==None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
setupext.py Outdated
| raiseRuntimeError('Microsoft VS 2010 required') | ||
| cmdfile=Path("build/build_freetype.cmd") | ||
| cmdfile.write_text( | ||
| FREETYPE_BUILD_CMD.format(vc20xx=vc,WinXX=WinXX,xXX=xXX)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
vcvarsall missing in format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
b4c85ec tob71fd6aCompare
PR Summary
Last chunk of breaking#11570 into smaller pieces.
PR Checklist