Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make CI fail if interactive toolkits can't be tested#11497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.travis.yml Outdated
| python -mpip install --upgrade $PRE pgi | ||
| python -c 'import pgi as gi; gi.require_version("Gtk", "3.0"); from pgi.repository import Gtk' | ||
| fi | ||
| python -c 'import PyQt5.QtCore' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These still need theecho bit to make sure the build doesn't fail if they aren't importable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually the point is exactly to fail when they are not importable, instead of having to figure this out manually every time this happens.
I have a hack solution to fix PyQt5 5.11 here, but I need to turn it into something reasonable. |
See#11500. |
PyQt5.11 has been withdrawn (https://riverbankcomputing.com/pipermail/pyqt/2018-June/040459.html), so I repurposed the PR to just move GUI deps to requirement files too and fail the CI when they fail to install properly. |
So it appears that the interactive tests are failing with wx+OSX. Any OSX specialist wants to have a look at this (can you repro locally?), or should we just skip them? |
I'm a little confused where we stand here. Right nownone of the Travis CI tests are passing because of QT5 issues. Is this fix, correct, or#11500? or are they complimentary? |
See#11500 (comment); as for this PR the scope has changed and I renamed it accordingly. |
requirements/testing/travis_all.txt Outdated
| # pgi is only installable on Linux | ||
| pyqt5 | ||
| # wxpython 4.0.2 is broken on OSX, see https://groups.google.com/forum/#!topic/wxpython-dev/lNvdniiXhdY | ||
| wxpython!=4.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like 4.0.3 is also failing now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's try excluding it too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fails to build faster! Actually I'm not clear why the mac build is trying to use 3.7....
Also make it a failure to fail to install the GUI toolkits for testing,to avoid missing new failures there.
Force-pushed a change to pin python to 3.6 for OS X. It was trying to use 3.7. |
Well, that didn't work either. Sorry, you should revert my commits... |
but now it's failing on something different (pyqt5). I'll try something later. |
This looks to be broken, but feel free to re-open if I'm wrong... |
I think some variant of this PR should still go in, but let's do thisafter the current qt breakage is fixed :) |
Uh oh!
There was an error while loading.Please reload this page.
PyQt5.11 appears to break the build (I can reproduce the failurelocally).
Also make it a failure to fail to install the GUI toolkits for testing,
to avoid missing new failures there.
Also supersedes#11494.
PR Summary
PR Checklist