Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: point align-ylabel demo to new align-label functions#11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromjklymak:doc-align-ylabels
Jun 21, 2018

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedJun 12, 2018
edited
Loading

@jklymakjklymak added this to thev2.2-doc milestoneJun 12, 2018
@jklymakjklymakforce-pushed thedoc-align-ylabels branch 2 times, most recently from097ad89 to2fecd9bCompareJune 12, 2018 17:57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Many examples indeed lack proper cross linking to similar/opposite/related cases. This is a step in the right direction.

@ImportanceOfBeingErnest
Copy link
Member

tbh I find the two big boxes on top a bit... too much. How did the Note box get introduced anyways? Can we get rid of that? I mean the page should start with its title, not with a note.

image

@jklymak
Copy link
MemberAuthor

jklymak commentedJun 12, 2018
edited
Loading

I didn't introduce that! sphinx-gallery maybe?

EDIT: WRT the second blue box, I think its justified - the new methods are much easier for most uses...

@ImportanceOfBeingErnest
Copy link
Member

I'm proposing to remove that box.

jklymak reacted with thumbs up emoji

@timhoffm
Copy link
Member

I’d rather have See also sections below the code. Having it up the is like saying “I’ll show you how to do alignment, but first you should look at these alternative ways.

Then again the referenced method is the simpler more standard case, which should come first.

The best solution would be to rewrite the example: First show a simple ˋalign_ylabel()ˋ example, then show the current code in case someone needs more control.

But I do not necessarily require this as part of this PR. Mentioning ˋalign_ylabel()ˋ is an improvement already.

@jklymak
Copy link
MemberAuthor

Well ok fair enough. On phone and can’t label but I agree that combining the examples is a better solution. So please don’t merge until I do that.

@jklymakjklymakforce-pushed thedoc-align-ylabels branch 3 times, most recently from7807912 to9adb067CompareJune 18, 2018 16:50
@jklymakjklymakforce-pushed thedoc-align-ylabels branch 2 times, most recently from3c27acc to0edc77cCompareJune 19, 2018 02:36
@jklymak
Copy link
MemberAuthor

@timhoffm are the changes ok? If so, we can merge...

@timhoffmtimhoffm merged commitb078643 intomatplotlib:masterJun 21, 2018
@lumberbot-app
Copy link

There seem to be a conflict, please backport manually

@jklymak
Copy link
MemberAuthor

jklymak commentedJun 21, 2018
edited
Loading

Not a big deal to bother w/ backport... Thanks@timhoffm!

@jklymakjklymak deleted the doc-align-ylabels branchJune 21, 2018 17:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@ImportanceOfBeingErnestImportanceOfBeingErnestImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@jklymak@ImportanceOfBeingErnest@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp