Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Figure equality-based tests.#11408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I like this! |
Seems useful. However, the new test is failing 😉 |
Yes, and I can't reproduce the failure locally... Can anyone else give it a try? |
@anntzer I just pulled your PR branch and ran Python 3.6.4 (from conda) |
yeah, sorry, works on my machine as well (well I skip svg) |
Interestingly my machine is a mac and it passes on my machine, and this passes the travis Mac tests. But not the linux ones. No idea whats going on here. |
Implement a `check_figures_equal` decorator, which allows tests whereboth the reference and the test image are generated. The idea is toallow tests of the form "this feature should be equivalent to that(usually more complex) way of achieving the same thing" without furtherbloating the test image directory.The saved images are properly created in the `result_images` folder, butcannot be "accepted" or "rejected" using the triage_tests UI (as thereis indeed no reference image to be saved in the repo).Includes an example use case.
Almost certain that the failure actually already existed previously on svg and pdf, except that we didn't actually test these two formats (only png) before; moreover that's likely due to old versions of inkscape and gs on travis. The new failure on Py3.5 is likely unrelated too. |
Implement a
check_figures_equaldecorator, which allows tests whereboth the reference and the test image are generated. The idea is to
allow tests of the form "this feature should be equivalent to that
(usually more complex) way of achieving the same thing" without further
bloating the test image directory.
The saved images are properly created in the
result_imagesfolder, butcannot be "accepted" or "rejected" using the triage_tests UI (as there
is indeed no reference image to be saved in the repo).
Includes an example use case. Other PRs that could use this feature
include#9426 and#11407.
PR Summary
PR Checklist