Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace :ref:sphx_glr_... by :doc:/....#11312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 2 commits intomatplotlib:masterfromanntzer:rerefs
May 29, 2018

Conversation

anntzer
Copy link
Contributor

The latter form is shorter, not specific to sphinx-gallery, maps more
cleanly to the actual path (no confusion between underscores and
slashes), and links to the example page itself rather than an anchor
just below it.

(Compare for examplehttps://matplotlib.org/devdocs/tutorials/colors/colors.html#sphx-glr-tutorials-colors-colors-py where the top is chopped off by the top banner and one needs to scroll up, vshttps://matplotlib.org/devdocs/tutorials/colors/colors.html)

Done by sed + manual checking.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzerforce-pushed thererefs branch 2 times, most recently from2e67a84 to233837bCompareMay 27, 2018 11:08
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't check all the links but I agree this is more readable in the source...

@tacaswelltacaswell added this to thev2.2.3 milestoneMay 29, 2018
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs a rebase

@anntzer can self-merge conditional on CI passing.

The latter form is shorter, not specific to sphinx-gallery, maps morecleanly to the actual path (no confusion between underscores andslashes), and links to the example page itself rather than an anchorjust below it.Done by sed + manual checking.
@anntzer
Copy link
ContributorAuthor

Self-merging per#11312 (review).

@anntzeranntzer merged commit2465e60 intomatplotlib:masterMay 29, 2018
@anntzeranntzer deleted the rerefs branchMay 29, 2018 06:51
@lumberbot-app
Copy link

There seem to be a conflict, please backport manually

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestAug 4, 2018
This also backported parts of other PRs making changes to the docs.Replace :ref:`sphx_glr_...` by :doc:`/...`.Conflicts:examples/color/color_cycler.py          - deleted, not present on 2.2.xexamples/axes_grid1/simple_anchored_artists.pyexamples/images_contours_and_fields/contour_image.pyexamples/images_contours_and_fields/quiver_demo.pyexamples/images_contours_and_fields/quiver_simple_demo.pyexamples/misc/anchored_artists.py          - keep master version
@tacaswell
Copy link
Member

backported to v2.2.x ase5ce40b

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@jklymak@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp