Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Prefer warn_deprecated instead of warnings.warn.#11297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4d94f3d tod3d9fadCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems good to me so long as you caught all the warnings associated w/ deprecations....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure why Travis OSX is failing. Seems unrelated.
warn_deprecated has the advantage of always listing the deprecationversion and removal version. Hopefully, in the future it will also beable to set the stacklevel more systematically.Redesign the way deprecation of rcParams is done to make it usewarn_deprecated. Merge obsolete_set into deprecated_ignore_map as theyare semantically similar, it's just that there's no alternative rcParamfor obsolete_set. Rename deprecated_set to deprecated_remain_as_none asthe former name really doesn't say anything about the deprecationsemantics.text.dvipnghack and axes.hold should be completely removed but that'llbe another PR.
warn_deprecated has the advantage of always listing the deprecation
version and removal version. Hopefully, in the future it will also be
able to set the stacklevel more systematically.
Redesign the way deprecation of rcParams is done to make it use
warn_deprecated. Merge obsolete_set into deprecated_ignore_map as they
are semantically similar, it's just that there's no alternative rcParam
for obsolete_set. Rename deprecated_set to deprecated_remain_as_none as
the former name really doesn't say anything about the deprecation
semantics.
text.dvipnghack and axes.hold should be completely removed but that'll
be another PR.
PR Summary
PR Checklist