NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Re-run boilerplate.py.#11251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:fix-pyplot

May 15, 2018

Merged

Re-run boilerplate.py.#11251

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:fix-pyplot

May 15, 2018

Conversation

Copy link

Contributor

anntzer commentedMay 15, 2018

Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.

xref#11234 (comment)

Planning to selfmerge as "unbreaking the build".

PR Summary

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Re-run boilerplate.py.

107431e

Also remove second blank line between cmap definitions, consistentlywith the other wrapper functions.

anntzer added the Build label

May 15, 2018

QuLogic approved these changes

May 15, 2018

View reviewed changes

QuLogic merged commit126113f intomatplotlib:master

May 15, 2018

QuLogic added this to thev3.0 milestone

May 15, 2018

Copy link

Member

QuLogic commentedMay 15, 2018

Merging to fix build issues.

anntzer deleted the fix-pyplot branch

May 15, 2018 05:12

Copy link

Member

timhoffm commentedMay 15, 2018

Just a remark:

Also remove second blank line between cmap definitions, consistently
with the other wrapper functions.

Technically, PEP-8 wants two blank lines between top-level functions. Not sure why it does not complain. Maybe we have deactivated that check, or the comment counts as blank line. Didn't check.

Copy link

ContributorAuthor

anntzer commentedMay 15, 2018

It's probably disabled for that specific file
PEP8 also says "Extra blank lines may be used (sparingly) to separate groups of related functions. Blank lines may be omitted between a bunch of related one-liners (e.g. a set of dummy implementations)." Yes, these are strictly speaking not one-liners, but I think it's close in spirit (and think 2 blank lines are totally pointless here).