Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify FreeType build.#11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:freetype-tarball
May 17, 2018
Merged

Conversation

anntzer
Copy link
Contributor

attn@timhoffm: breaking#11235 into smaller pieces.

  • Reformat a bunch of strings.
  • Rely on Python's tarfile module to extract the FreeType tarball,
    instead of the "tar" executable (because we need to use Python's
    tarfile on Windows anyways, so we may as well do it on all OSes).
  • For the Unix build, call./configure andmake without
    shell=True, instead setting CFLAGS in the environment as needed.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- Reformat a bunch of strings.- Rely on Python's tarfile module to extract the FreeType tarball,  instead of the "tar" executable (because we need to use Python's  tarfile on Windows anyways, so we may as well do it on all OSes).- For the Unix build, call `./configure` and `make` without  `shell=True`, instead setting CFLAGS in the environment as needed.
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Much nicer to review! 😄

@jklymak
Copy link
Member

Hard to see how the Appveyor test failure is related...

@jklymakjklymak merged commit6017a93 intomatplotlib:masterMay 17, 2018
@anntzeranntzer deleted the freetype-tarball branchMay 17, 2018 16:52
@QuLogicQuLogic added this to thev3.0 milestoneMay 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@jklymak@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp