NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Remove mplDeprecation#11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromtimhoffm:cleanup-mplDeprecation

Jul 9, 2018

Merged

Remove mplDeprecation#11247

tacaswell merged 1 commit intomatplotlib:masterfromtimhoffm:cleanup-mplDeprecation

Jul 9, 2018

Conversation

Copy link

Member

timhoffm commentedMay 15, 2018•
edited
Loading

This is just an alias toMatplotlibDeprecationWarning. Explicitly using the latter is preferred.

Is cbook considered public API? If so, we have do add a deprecation cycle formplDeprecation.

PR Checklist

Code is PEP 8 compliant
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell added this to thev3.0 milestone

May 15, 2018

Copy link

Member

tacaswell commentedMay 15, 2018

cbook is public API. We are going to deprecate the deprecation? 😈

Copy link

Contributor

anntzer commentedMay 15, 2018

#10735 may be useful here...

timhoffm force-pushed thecleanup-mplDeprecation branch 3 times, most recently from0a35d2a to9ea3babCompare

May 16, 2018 06:01

Copy link

MemberAuthor

timhoffm commentedMay 16, 2018

@anntzer Thanks for the hint on#10735. It's an interesting approach. However I think it's a bit overkill for the present case.

Likely, very few people will usemplDeprecation. It's not part of the docs (except for a mention in a list of changes). Users who want to filter out warnings will have usedMatplotlibDeprecationWarning since this is what they will have seen as the warning type.

I've added a deprecation note and think that's enough.

timhoffm added the status: needs review label

May 18, 2018

jklymak approved these changes

May 25, 2018

View reviewed changes

doc/api/next_api_changes/2018-05-16-TH.rst Outdated

		`````````````````````````````````````````````````````````````

		:class:`matplotlib.cbook.deprecation.mplDeprecation` will be removed in
		future versions. It is just an for

Copy link

Member

jklymakMay 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume "It is just an alias for"...

timhoffm force-pushed thecleanup-mplDeprecation branch from9ea3bab to351636cCompare

May 26, 2018 14:45

Copy link

Contributor

anntzer commentedMay 26, 2018

Likely, very few people will use mplDeprecation.

You mean, like#10716? :) I would also like to see it go away, but I'll leave it to@tacaswell to make the final call.

Copy link

MemberAuthor

timhoffm commentedMay 26, 2018

cbook.mplDeprecation still exists. Do we also still needmatplotlib.mplDeprecation andmatplotlib.pyplot.mplDeprecation?

timhoffm force-pushed thecleanup-mplDeprecation branch 2 times, most recently fromf5dbacd to1c5c86dCompare

June 3, 2018 19:43

Copy link

MemberAuthor

timhoffm commentedJun 3, 2018

To be on the safe side, I've keptmatplotlib.mplDeprecation andmatplotlib.pyplot.mplDeprecation for now. Will be removed after the deprecation period.

jkseppan reviewed

Jun 4, 2018

View reviewed changes

lib/matplotlib/__init__.py Outdated

		frommatplotlib.cbookimport (
		mplDeprecation,dedent,get_label,sanitize_sequence)
		MatplotlibDeprecationWarning,dedent,get_label,sanitize_sequence)
		fommatplotlib.cbookimportmplDeprecation# deprecated

Copy link

Member

jkseppanJun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can't be right? Should readfrom instead offom.

timhoffm force-pushed thecleanup-mplDeprecation branch 2 times, most recently fromd8a7c80 to4fd04f9Compare

June 4, 2018 18:26

dstansby added the status: needs rebase label

Jun 25, 2018

timhoffm force-pushed thecleanup-mplDeprecation branch from4fd04f9 toc0c33cdCompare

July 1, 2018 20:53

Copy link

Contributor

anntzer commentedJul 1, 2018

Not to be a pain :-) but I would appreciate if#11297 (which completely gets rid of quite a few of these mplDeprecations, rather than just renaming them; and which is already approved twice) could go in first...

timhoffm force-pushed thecleanup-mplDeprecation branch fromc0c33cd toeb0bbfaCompare

July 1, 2018 22:57

anntzer reviewed

Jul 1, 2018

View reviewed changes

lib/matplotlib/pyplot.py Outdated

		frommatplotlibimport_pylab_helpers,interactive
		frommatplotlib.cbookimport (
		dedent,deprecated,silent_list,warn_deprecated,_string_to_bool)
		frommatplotlib.cbookimportmplDeprecation# deprecated