Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove mplDeprecation#11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedMay 15, 2018•
edited
Loading

This is just an alias toMatplotlibDeprecationWarning. Explicitly using the latter is preferred.

Is cbook considered public API? If so, we have do add a deprecation cycle formplDeprecation.

PR Checklist

  • Code is PEP 8 compliant
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswelltacaswell added this to thev3.0 milestoneMay 15, 2018
@tacaswell
Copy link
Member

cbook is public API. We are going to deprecate the deprecation? 😈

@anntzer
Copy link
Contributor

#10735 may be useful here...

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch 3 times, most recently from0a35d2a to9ea3babCompareMay 16, 2018 06:01
@timhoffm
Copy link
MemberAuthor

@anntzer Thanks for the hint on#10735. It's an interesting approach. However I think it's a bit overkill for the present case.

Likely, very few people will usemplDeprecation. It's not part of the docs (except for a mention in a list of changes). Users who want to filter out warnings will have usedMatplotlibDeprecationWarning since this is what they will have seen as the warning type.

I've added a deprecation note and think that's enough.

Zac-HD and jkseppan reacted with thumbs up emoji

`````````````````````````````````````````````````````````````

:class:`matplotlib.cbook.deprecation.mplDeprecation` will be removed in
future versions. It is just an for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume "It is just an alias for"...

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch from9ea3bab to351636cCompareMay 26, 2018 14:45
@anntzer
Copy link
Contributor

Likely, very few people will use mplDeprecation.

You mean, like#10716? :) I would also like to see it go away, but I'll leave it to@tacaswell to make the final call.

@timhoffm
Copy link
MemberAuthor

cbook.mplDeprecation still exists. Do we also still needmatplotlib.mplDeprecation andmatplotlib.pyplot.mplDeprecation?

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch 2 times, most recently fromf5dbacd to1c5c86dCompareJune 3, 2018 19:43
@timhoffm
Copy link
MemberAuthor

To be on the safe side, I've keptmatplotlib.mplDeprecation andmatplotlib.pyplot.mplDeprecation for now. Will be removed after the deprecation period.

@@ -140,7 +140,8 @@
# definitions, so it is safe to import from it here.
from . import cbook
from matplotlib.cbook import (
mplDeprecation, dedent, get_label, sanitize_sequence)
MatplotlibDeprecationWarning, dedent, get_label, sanitize_sequence)
fom matplotlib.cbook import mplDeprecation # deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can't be right? Should readfrom instead offom.

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch 2 times, most recently fromd8a7c80 to4fd04f9CompareJune 4, 2018 18:26
@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch from4fd04f9 toc0c33cdCompareJuly 1, 2018 20:53
@anntzer
Copy link
Contributor

Not to be a pain :-) but I would appreciate if#11297 (which completely gets rid of quite a few of these mplDeprecations, rather than just renaming them; and which is already approved twice) could go in first...

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch fromc0c33cd toeb0bbfaCompareJuly 1, 2018 22:57
@@ -33,6 +33,7 @@
from matplotlib import _pylab_helpers, interactive
from matplotlib.cbook import (
dedent, deprecated, silent_list, warn_deprecated, _string_to_bool)
from matplotlib.cbook import mplDeprecation # deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this isn't needed?

@timhoffmtimhoffmforce-pushed thecleanup-mplDeprecation branch fromeb0bbfa toa1419ccCompareJuly 2, 2018 00:02
@tacaswelltacaswell merged commit1209037 intomatplotlib:masterJul 9, 2018
@tacaswell
Copy link
Member

Thanks@timhoffm !

@timhoffmtimhoffm deleted the cleanup-mplDeprecation branchJuly 9, 2018 05:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkseppanjkseppanjkseppan left review comments

@anntzeranntzeranntzer left review comments

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

7 participants
@timhoffm@tacaswell@anntzer@jkseppan@jklymak@QuLogic@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp