Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.2k
Inline setup_external_build into setupext.#11235
Inline setup_external_build into setupext.#11235anntzer wants to merge 1 commit intomatplotlib:masterfrom
Conversation
| vcvarsall = msvc.find_vcvarsall(10.0) | ||
| if vcvarsall is None: | ||
| raise RuntimeError("Microsoft VS 2010 required") | ||
| X64 = sys.maxsize > 2 ** 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seehttps://docs.python.org/3/library/platform.html#platform.architecture for why we check bitsize in this manner.
c9400a0 to8b0e03fCompareAlso:- use tarfile to extract the FreeType tarball on all platforms.- less batch script, more Python.- more pathlib, less shell=True.
timhoffm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, I lost overview (and motivation to review) half way through the PR.
Can you please try to not mix larger structural/logical changes with many tiny cleanups? I know it's handy to change theses things as you go along. However, two separate PRs would be much easier to review.
| urllib.request.urlretrieve(tarball_url, tarball_path) | ||
| except IOError: # URLError (a subclass) on Py3. | ||
| print("Failed to download {0}".format(tarball_url)) | ||
| except IOError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changed in version 3.3: URLError has been made a subclass of OSError instead of IOError.
https://docs.python.org/3/library/urllib.error.html
We should check for the more specificurllib.error.URLError anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IOError is an alias of OSError since 3.3 (see just afterhttps://docs.python.org/3/library/exceptions.html#ZeroDivisionError).
anntzer commentedMay 15, 2018
Sounds fair, will split the PR. |
jklymak commentedJul 5, 2018
So this can be closed, right? |
anntzer commentedJul 5, 2018
Yes. |
Also:
PR Summary
PR Checklist