Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Inline setup_external_build into setupext.#11235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| vcvarsall = msvc.find_vcvarsall(10.0) | ||
| if vcvarsall is None: | ||
| raise RuntimeError("Microsoft VS 2010 required") | ||
| X64 = sys.maxsize > 2 ** 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seehttps://docs.python.org/3/library/platform.html#platform.architecture for why we check bitsize in this manner.
c9400a0 to8b0e03fCompareAlso:- use tarfile to extract the FreeType tarball on all platforms.- less batch script, more Python.- more pathlib, less shell=True.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, I lost overview (and motivation to review) half way through the PR.
Can you please try to not mix larger structural/logical changes with many tiny cleanups? I know it's handy to change theses things as you go along. However, two separate PRs would be much easier to review.
| try: | ||
| urllib.request.urlretrieve(tarball_url, tarball_path) | ||
| except IOError: # URLError (a subclass) on Py3. | ||
| print("Failed to download {0}".format(tarball_url)) | ||
| except IOError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changed in version 3.3: URLError has been made a subclass of OSError instead of IOError.
https://docs.python.org/3/library/urllib.error.html
We should check for the more specificurllib.error.URLError anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IOError is an alias of OSError since 3.3 (see just afterhttps://docs.python.org/3/library/exceptions.html#ZeroDivisionError).
Sounds fair, will split the PR. |
So this can be closed, right? |
Yes. |
Also:
PR Summary
PR Checklist