Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use explicit kwarg for plt.show()#11170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/pyplot.py Outdated
| """ | ||
| global _show | ||
| return _show(*args, **kw) | ||
| return _show(block=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess you meanreturn _show(block=block) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤦♂️
I do think it's a good idea. Maybe one could even check for |
Apparently there is a problem with the web backend which doesn't take any arguments. |
b8806d5 tod4d80e5Compare| @@ -319,7 +319,10 @@ def trigger_manager_draw(manager): | |||
| manager.canvas.draw_idle() | |||
| @staticmethod | |||
| def show(): | |||
| def show(block=True): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought we fixed this already....
I am 👎 on changing the default value. If the user passed I am very 👍 on@ImportanceOfBeingErnest 's suggestion of giving a good warning in the common incorrect use of passing figures or axes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👎 on changing the default.
If the user passesblock=True we need to block!
dstansby commentedMay 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is there currently a difference between |
Concerning |
Going to close this since I can't remember what's going on. |
I feel like this might be a Bad Idea, but can't work out why - maybe others will be able to tell me if it is or not! Either way, the doc change is probably welcome.
Will add API notes if/when someone reviews.