Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove mpl_examples symlink.#11141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AFAICT we're not using it for anything, we don't have a similar symlinkto the tutorials, and it annoys my tab-completion when I try to get intompl_toolkits...
does this affect what goes into the build products when we release? |
The docs look fine. Is it there to maintain links? Or maybe archived links instead of returning a 404? |
The sdist actually contains 2 copies of the examples, as the tgz (or probably the distutils archiver) doesn't keep mpl_examples as a symlink. |
This will need a deprecation note then is case down-stream consumers are expecting this directory. |
Not sure how you want to word this, can you directly push to the PR? |
tacaswell commentedApr 30, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
nvm, I can't read, that symlink was in doc, not in lib. |
@sandrotosi@QuLogic Can you verify this won't mess up debian and fedora packaging? |
QuLogic commentedMay 1, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We don't install it, and currently don't even build the docs, so I'm not sure it's really needed here. |
thanks@tacaswell for checking with the distro packagers! yes this should be fine for debian (you plan on keep distributing the |
@sandrotosi Yes |
Due to the removal of the symlink inmatplotlib#11141, pytest was no longerpicking up the examples and running pep8 on them.
Due to the removal of the symlink inmatplotlib#11141, pytest was no longerpicking up the examples and running pep8 on them.
AFAICT we're not using it for anything, we don't have a similar symlink
to the tutorials, and it annoys my tab-completion when I try to get into
mpl_toolkits...
PR Summary
PR Checklist