Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove mpl_examples symlink.#11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 2 commits intomatplotlib:masterfromanntzer:mpl_examples
May 6, 2018
Merged

Conversation

anntzer
Copy link
Contributor

AFAICT we're not using it for anything, we don't have a similar symlink
to the tutorials, and it annoys my tab-completion when I try to get into
mpl_toolkits...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

AFAICT we're not using it for anything, we don't have a similar symlinkto the tutorials, and it annoys my tab-completion when I try to get intompl_toolkits...
@anntzeranntzer added this to thev3.0 milestoneApr 29, 2018
@tacaswell
Copy link
Member

does this affect what goes into the build products when we release?

@jklymak
Copy link
Member

The docs look fine. Is it there to maintain links? Or maybe archived links instead of returning a 404?

@anntzer
Copy link
ContributorAuthor

The sdist actually contains 2 copies of the examples, as the tgz (or probably the distutils archiver) doesn't keep mpl_examples as a symlink.
Other than that, I don't think anything changes.

@tacaswell
Copy link
Member

This will need a deprecation note then is case down-stream consumers are expecting this directory.

@anntzer
Copy link
ContributorAuthor

Not sure how you want to word this, can you directly push to the PR?

@tacaswell
Copy link
Member

tacaswell commentedApr 30, 2018
edited
Loading

This is the second time you have removed this symlink...#9708 🐑

nvm, I can't read, that symlink was in doc, not in lib.

@tacaswell
Copy link
Member

@sandrotosi@QuLogic Can you verify this won't mess up debian and fedora packaging?

@QuLogic
Copy link
Member

QuLogic commentedMay 1, 2018
edited
Loading

We don't install it, and currently don't even build the docs, so I'm not sure it's really needed here.

@sandrotosi
Copy link
Contributor

thanks@tacaswell for checking with the distro packagers! yes this should be fine for debian (you plan on keep distributing theexamples/ dir in the tarballs right?)

@efiringefiring merged commitcefc5c7 intomatplotlib:masterMay 6, 2018
@anntzeranntzer deleted the mpl_examples branchMay 6, 2018 09:36
@tacaswell
Copy link
Member

@sandrotosi Yes

QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestJun 22, 2018
Due to the removal of the symlink inmatplotlib#11141, pytest was no longerpicking up the examples and running pep8 on them.
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestJun 23, 2018
Due to the removal of the symlink inmatplotlib#11141, pytest was no longerpicking up the examples and running pep8 on them.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@efiringefiringefiring approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

6 participants
@anntzer@tacaswell@jklymak@QuLogic@sandrotosi@efiring

[8]ページ先頭

©2009-2025 Movatter.jp